CheckedRegions understand return types, fixes #263 #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhicks1
reviewed
Dec 18, 2020
mwhicks1
reviewed
Dec 18, 2020
| if (isTopLevel(Context, S)) { | ||
| const auto &Parents = Context->getParents(*S); | ||
| assert(!Parents.empty()); | ||
| FunctionDecl* Parent = const_cast<FunctionDecl*>(Parents[0].get<FunctionDecl>()); |
There was a problem hiding this comment.
Why does Parent need to be non-const ?
There was a problem hiding this comment.
Because ProgramInfo::getVariable takes a non-const
There was a problem hiding this comment.
I think we might be able to make the parameter of getVariable const. We should rarely if ever be mutating this sort of clang AST node object. Perhaps not as part of this PR, but in a later change we could add const annotations to these AST node objects where we can.
There was a problem hiding this comment.
Ok, I'm happy to go through and try to make that change.
There was a problem hiding this comment.
But, per the status meeting: Let's just do this as a separate PR; leave the const_cast for now.
mwhicks1
reviewed
Dec 18, 2020
aaronjeline
changed the title
mwhicks1
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main question I have is on my
const_castat checkedregions.c:173. Is there a way to avoid this, without needing to change the entire project to makeProgramInfo::getVariableconst?